'up' attribute not supported in pgc

[lu-zero]

<pgc entry="subtitle" up="1">

[ldo]

What should it do?

[lu-zero]

I can see there is an 'up', 'next', and 'prev' attributes

          /* add pgc nav info */
            if (pgc->goup_pgc_nr)
              {
                AddAttribute(pgcNode, "up", "%d", pgc->goup_pgc_nr);
              } /*if*/
            if (pgc->next_pgc_nr)
              {
                AddAttribute(pgcNode, "next", "%d", pgc->next_pgc_nr);
              } /*if*/
            if (pgc->prev_pgc_nr)
              {
                AddAttribute(pgcNode, "prev", "%d", pgc->prev_pgc_nr);
              } /*if*/

but simply grepping to check where those are set returns nothing (I couldn't see how that struct is populated)

[ldo]

So what is it supposed to do?

[lu-zero]

spent a little time to read dvdread and dvdnav

We have those 3 values

  B2N_16(pgc->next_pgc_nr);
  B2N_16(pgc->prev_pgc_nr);
  B2N_16(pgc->goup_pgc_nr);

And apparently they can be used to:

• automatically go to the next pgc (play.c play_PGC_post in dvdnav)
• move up one level, next or prev by the external controls.

[ldo]

Sutmit a patch, then.