search

ldoge / LDOGE

LITEDOGE - Proof of Stake: 2.0 Proof, of work: Scrypt
https://litedogeofficial.org
MIT License
40 stars 21 forks source link

Fixes for someone doing changes in assert :( #33

Closed skyrawrcode closed 3 years ago

skyrawrcode commented 3 years ago

assert is not supposed to be used with code that has side effects. Some compilers when in release mode replace assert with void(0) which is a no-operation. This can cause lost funds when a change address is generated and not saved because the assert method removed the save.

nerdlabs001 commented 3 years ago

Sorry for the delay I will look shortly and merge

On Fri, May 28, 2021, 11:17 PM Shawn M. @.***> wrote:

Merged #33 https://github.com/ldoge/LDOGE/pull/33 into master.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ldoge/LDOGE/pull/33#event-4815562105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJKNCDJGZLG3GS7W3TVAKHLTQBTFLANCNFSM45XUF62Q .