search

ldsec / glowing-bear-medco

Cohort-selection UI for MedCo. Fork of Glowing Bear :bear: (glowingbear.app).
https://medco.epfl.ch/documentation
Mozilla Public License 2.0
2 stars 4 forks source link

Running a survival analysis with a time limit of 0 triggers a server-side error #199

Closed prosticoco closed 3 years ago

prosticoco commented 3 years ago

When running a survival analysis with a time limit with value 0 (days/weeks/months/years) triggers a server-side error. Screenshot from 2021-04-05 13-24-51 Screenshot from 2021-04-05 13-25-00

Steps taken:

  1. Enter Analysis tab and then survival
  2. select all_subjects from the saved cohorts sidebar
  3. Set a value of 0 for the time limit in the settings panel
  4. Add any start and end events
  5. Run the query
mickmis commented 3 years ago

Indeed, a frontend-side check should be done for the validity of this value. How: throw a UserInputError when the query input is checked (check #185 where this was introduced).

@JoaoAndreSa @f-marino assigning you both, up to you who takes care of it.

mickmis commented 3 years ago

Actually this seems to be fixed by #187. Can you confirm @nfreundl ?

nfreundl commented 3 years ago

Duplicate of https://github.com/ldsec/glowing-bear-medco/issues/183