search

ldsec / glowing-bear-medco

Cohort-selection UI for MedCo. Fork of Glowing Bear :bear: (glowingbear.app).
https://medco.epfl.ch/documentation
Mozilla Public License 2.0
2 stars 4 forks source link

inconsistent results for numeric queries with different operators #61

Closed JLRaisaro closed 3 years ago

JLRaisaro commented 3 years ago

For numeric queries it seems that the operators "equals to" and "different from" and "lower or equal to" yield the same result (ex. A152-height = 6 => 24 subjects, A152-height != 6 => 24 subjects, A152-height <= 6 => 24 subjects A152-height any => 360 subjects, A152-height < 6 => 75 subjects). Moreover the sum of results obtained with "lower than", "greater than" and "equals to" 6 yield 381 subjects whereas "any" yields 360 subjects...

f-marino commented 3 years ago

I tried your query from the CLI and everything works as expected, so the problem is in Glowing Bear. Other inconsistencies you are finding in the results are due to inconsistencies in the dataset, i.e. there are patients that have two heights (e.g., 79 and 347).

JLRaisaro commented 3 years ago

ok for the second problem. We should then check with Nicolas for the Glowingbear part.

On Mon, 15 Feb 2021 at 16:13, Francesco Marino notifications@github.com wrote:

I tried your query from the CLI and everything works as expected, so the problem is in Glowing Bear. Other inconsistencies you are finding in the results are due to inconsistencies in the dataset, i.e. there are patients that have two heights (e.g., 79 and 347).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ldsec/medco/issues/76#issuecomment-779284534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2BAWBMMW2H3KDEK6USA33S7E22XANCNFSM4XUU5TGQ .