Fix fancy_light_spec.json

ldtteam / Domum-Ornamentum

GNU General Public License v3.0

11 stars 26 forks source link

Fix fancy_light_spec.json #230

Closed glorantq closed 8 months ago

glorantq commented 8 months ago

This commit fixes the broken texture references in the model of the fancy framed light

CLAassistant commented 8 months ago

All committers have signed the CLA.

CLAassistant commented 8 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Thodor12 commented 8 months ago

Can you show any relevant errors, before and afters? There has to be some reason to make this.

glorantq commented 8 months ago

No logs, I found this issue while rendering blocks with a third party tool. The reason to make this is that this file is not correct. While the game functions fine with the # missing, it should be there for texture references, just like it is there with all the other models.

Thodor12 commented 8 months ago

Need verification it still works in-game in that case. We don't base code around any random third party tool, the important part is that it works in game.

Raycoms commented 8 months ago

Just a quick screenshot with your changes would be enough already

glorantq commented 8 months ago

It does work in game.