ldtteam / Domum-Ornamentum

GNU General Public License v3.0
11 stars 26 forks source link

Snow on Tiled Roofs #56

Open Zygus42 opened 5 years ago

Zygus42 commented 5 years ago

minecolonies-1.12.2-0.10.351-ALPHA-universal

Expected behavior

Snow fitting to roof tile shape.

Actual behaviour

2019-09-25_20 18 14

Steps to reproduce the problem

Let it snow.

Asherslab commented 5 years ago

there's nothing we can generally do about that other than simply disabling snow on our roof tiles

Raycoms commented 5 years ago

Theoretically we could make our own version of "snow" which is smoother on it. I think there is stuff for that probably.

Am Fr., 27. Sept. 2019 um 06:28 Uhr schrieb AshersLab < notifications@github.com>:

there's nothing we can generally do about that other than simply disabling snow on our roof tiles

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ldtteam/Domum-Ornamentum/issues/56?email_source=notifications&email_token=ABRD3S5JRKYMPQZQRRYTJ33QLXG3DA5CNFSM4I2MHW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7YKUZQ#issuecomment-535865958, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRD3SZEEBP3GHEEAC7I77LQLXG3DANCNFSM4I2MHW4Q .

Asherslab commented 5 years ago

possibly? however snow is an actual block so we couldn't just adjust that. instead we'd have to have seperate models for our shingles, which would also mean in the very least twice as many models

Raycoms commented 5 years ago

No possibility for an overlay or something like that? If not, we can just set that snow can't land on any of our shingles or shingle slabs.

Am Fr., 27. Sept. 2019 um 06:32 Uhr schrieb AshersLab < notifications@github.com>:

possibly? however snow is an actual block so we couldn't just adjust that. instead we'd have to have seperate models for our shingles, which would also mean in the very least twice as many models

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ldtteam/Domum-Ornamentum/issues/56?email_source=notifications&email_token=ABRD3S6U2MEDKMA4U52L3PLQLXHJ3A5CNFSM4I2MHW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7YK7OA#issuecomment-535867320, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRD3S7TUTFV6CFKOVHY5QTQLXHJ3ANCNFSM4I2MHW4Q .

Asherslab commented 5 years ago

an overlay? not sure what you mean there, any rendering is done via models.

Raycoms commented 5 years ago

I don't know, something like what is done with the waterlogged stuff of blocks.

Am Fr., 27. Sept. 2019 um 06:57 Uhr schrieb AshersLab < notifications@github.com>:

an overlay? not sure what you mean there, any rendering is done via models.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ldtteam/Domum-Ornamentum/issues/56?email_source=notifications&email_token=ABRD3SZDLQUCCSWZ4I334ODQLXKKBA5CNFSM4I2MHW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7YNALQ#issuecomment-535875630, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRD3S4KNUWGZWSQTCYRWTDQLXKKBANCNFSM4I2MHW4Q .

cltnschlosser commented 5 years ago

Could you just use a different texture?

Colton Schlosser

On Sep 27, 2019, at 4:59 AM, Raycoms notifications@github.com wrote:

I don't know, something like what is done with the waterlogged stuff of blocks.

Am Fr., 27. Sept. 2019 um 06:57 Uhr schrieb AshersLab < notifications@github.com>:

an overlay? not sure what you mean there, any rendering is done via models.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ldtteam/Domum-Ornamentum/issues/56?email_source=notifications&email_token=ABRD3SZDLQUCCSWZ4I334ODQLXKKBA5CNFSM4I2MHW42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7YNALQ#issuecomment-535875630, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRD3S4KNUWGZWSQTCYRWTDQLXKKBANCNFSM4I2MHW4Q .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Asherslab commented 5 years ago

@cltnschlosser would require a different model (as mentioned) @Raycoms waterlogged is a full block of water "overlayed" while that would technically work, that's not how snow layers usually look in MC, it would be really weird looking that way, plus it wouldn't be solid, we'd also have to create a crap tonne of code to mimic that vanilla behaviour (waterlogged blocks changed crap tonnes of stuff in mc)

Raycoms commented 5 years ago

OKay, then we should probably just disable snow on them

Zygus42 commented 5 years ago

There's several mods that add snow layers to stairs etc, but I tried them all when i was building my latest mod pack, and they use weird workarounds that are not very server friendly.

Asherslab commented 5 years ago

@Zygus42 yes there are mods that enable that type of thing, however that would require us to also add code to either support those mods, or add those types of features into our own, this isn't something that we'd really want to do, nor would it be very feasible due to the fact that our shingles, while similar to stairs and technically are stairs, have different models/textures/etc from stairs

Zygus42 commented 5 years ago

I wasn't suggesting you do, in fact, I was just pointing out that there doesn't seem an easy solution to this problem in minecraft as it stands. Without, as you say, adding new models for a fairly fringe situation. On the other hand, snow would fit the look of your tile set perfectly, making it look like a european christmas scene.