search

ldtteam / DynView

Small serverside utility to balance load and chunk view distance
GNU General Public License v3.0
22 stars 7 forks source link

viewDistanceUpdateRate Config Does Not Appear To Be Used #16

Closed r-mc2 closed 3 years ago

r-mc2 commented 3 years ago

Mod Version

dynviewdist-1.9

MC Version

v1.16.5

Issue

I've been tweaking how often I let the mod do it's check to alter view distance and currently I've set it to 90 seconds in the config file. However it appears to be using some internal default of 45 seconds:

[11Mar2021 16:36:41.324] [Server thread/INFO] [com.dynamic_view.DynView/]: Mean tick: 25ms increasing chunk view distance to: 8
...
[11Mar2021 16:37:26.315] [Server thread/INFO] [com.dynamic_view.DynView/]: Mean tick: 27ms increasing chunk view distance to: 9
...
[11Mar2021 16:38:11.332] [Server thread/INFO] [com.dynamic_view.DynView/]: Mean tick: 30ms increasing chunk view distance to: 10
...
[11Mar2021 16:38:56.324] [Server thread/INFO] [com.dynamic_view.DynView/]: Mean tick: 40ms increasing chunk view distance to: 11

For reference the config line I'm using viewDistanceUpdateRate = 90 The comment above it leads me to believe this is an input in seconds and not ms. Correct?

someaddons commented 3 years ago

it is used, you might need a restart for it to take effect afaik forge got some config issues

r-mc2 commented 3 years ago

Hmm, I had actually restarted the server a few times between testing changing this config. I never expect config changes to stick if the server is still up. The output in the server log was always 45 seconds though.

Might it be a /config vs /<world-folder>/serverconfig/*.toml issue?