ldtteam / MinecoloniesWiki

Wiki for the Minecraft mod MineColonies
https://wiki.minecolonies.com
GNU General Public License v3.0
12 stars 153 forks source link

Add Structurize Frame crafting info to Carpenter wiki page #1030

Closed Rsge closed 6 months ago

Rsge commented 6 months ago

Changes proposed:

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

MotionlessTrain commented 6 months ago

Those blocks are not part of Structurize anymore since minecraft 1.17, and they now never need a build tool to be crafted anyway (but the architect's cutter). There is already information on the Domum Ornamentum page, which those blocks are now a part of

Rsge commented 6 months ago

@MotionlessTrain Is there a 1.16-and-below version of the wiki then, where I could find this info for the version I'm playing? I couldn't find one. If not, I think it'd be helpful to add the info with a version disclaimer / a new selectable sub-version (as right now I see only 1.19+), as I'm sure there are others going through the same trouble as me, still playing on older versions. Though I can understand if you don't want to, as these older versions are probably not supported anymore and would be too much additional work maybe not worth the effort.

MotionlessTrain commented 6 months ago

The wiki reflects the currently supported minecraft versions, which are 1.19.2 and 1.20.1. There might still be some information from before those versions available (which would be visible when you add ?version=1.18.2 or ?version=1.16.5 etc. to the url)

Rsge commented 6 months ago

That's fair.\ Sadly, the page shown with 1.16.5 selected as you instructed is the same as in newer versions. Could I tag my addition to only be shown when the selected version is 1.16 and lower? Or is there a separate file needed for that? (I didn't find anything when searching 1.16.5 in this repo.) Is it even worth the trouble you think? (Probably not?) If not feel free to close this if you have the permission. In any case, thanks for the explanations.

MotionlessTrain commented 6 months ago

I don't think it is worth the trouble Unfortunately, I have no permissions to close the PR

You're welcome!