search

ldtteam / MinecoloniesWiki

Wiki for the Minecraft mod MineColonies
https://wiki.minecolonies.com
GNU General Public License v3.0
12 stars 153 forks source link

Update schematics.mdoc #1049

Closed Talyda closed 4 months ago

Talyda commented 4 months ago

Adding new numbers for fishing pond size

new numbers from discord discussion here

Closes #

Changes proposed:

Talyda commented 4 months ago

Update the cases on the worker and building page as well, I didn't know this one was also there, but otherwise we still have conflicting info.

(To be honest we should probably remove this occurence since it's not mandatory)

No, it shouldn't be removed, cos schematics makers still need to know it

I also have no idea how to add to a PR to change the other pages, so please approve this one, and I will change the others separately later

Thodor12 commented 4 months ago

@Talyda You can go and make changes to any extra files you want. But in the dialog where it tells you to commit, it'll ask you whether you want to make a new branch, or add the changes to an existing branch. You have to choose existing branch and select "Talyda:patch-5" (the branch you made this PR from)

Thodor12 commented 4 months ago

I've changed this with https://github.com/ldtteam/MinecoloniesWiki/commit/63509d58e83831839ba42cd38ce186a221be02bb to further mitigate any issues with conflicting pond sizes (and potentially other common pieces of info later on)

Talyda commented 4 months ago

choose existing branch and select "Talyda:patch-5" (the branch you made this PR from)

Ah! Okey dokey! Thanks Thodor!