ldtteam / MinecoloniesWiki

Wiki for the Minecraft mod MineColonies
https://wiki.minecolonies.com
GNU General Public License v3.0
12 stars 150 forks source link

Adjustments to the mine page, to reflect the new depth thresholds #1050

Closed MotionlessTrain closed 1 month ago

MotionlessTrain commented 1 month ago

Closes #

Changes proposed:

Talyda commented 1 month ago

Thresholds are predefined depths which are determined based on the building level, and the initial depth of the building, these depths are: 48, 16, -16 and Bedrock.

Shouldn't that be "Thresholds are predefined depths which are determined based on the building level, and the initial depth of the first platform"?

Or I am still confused by the new system?

MotionlessTrain commented 1 month ago

Thresholds are predefined depths which are determined based on the building level, and the initial depth of the building, these depths are: 48, 16, -16 and Bedrock.

Shouldn't that be "Thresholds are predefined depths which are determined based on the building level, and the initial depth of the first platform"?

Or I am still confused by the new system?

It is indeed based on the initial depth of the first platform, which itself is determined by the Y-level the building is built at (and the style of the mine)

I can see how it is confusing now (as I refer to this first platform right above that). I will change it this evening, as I don't think my tablet will allow editing the PR Edit: apparently using suggestions, it is possible to make commits on tablet. I already changed it

Talyda commented 1 month ago

Edit: apparently using suggestions, it is possible to make commits on tablet. I already changed it

You're quick!

And sorry but I can't work out where to comment directly on the changes, you have "If the miner builds there first platform at Y 48 or above" and it should be "their first platform"

MotionlessTrain commented 1 month ago

Edit: apparently using suggestions, it is possible to make commits on tablet. I already changed it

You're quick!

And sorry but I can't work out where to comment directly on the changes, you have "If the miner builds there first platform at Y 48 or above" and it should be "their first platform"

I blame autocorrect (or the fact that the words are pronounced the same)

Those comments got marked as resolved, but you could still open them and add a comment there

MotionlessTrain commented 1 month ago

There's still cases where the building/worker name are directly used, but I'll be doing a mass replace of those at some point, so it's okay for now

There were quite a few of those on the page already. I was uncertain which of those were intended to be used directly, and which of those never were converted to their link version

Thodor12 commented 1 month ago

In essence, all of them have to be converted. This is because this also handles versioned building/worker name changes. (I.e. House -> Residence)