Closed stolencatkarma closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: stolencatkarma
:x: enjia2000
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
A mineshaft is not a building, so a link to a building page named "mineshaft" won't work There are by the way more mine nodes than just a mineshaft. The minermainshaft is just the piece miners use to go vertical
So are you proposing i close this issue?
On Thu, Jun 22, 2023 at 3:19 PM MotionlessTrain @.***> wrote:
A mineshaft is not a building, so a link to a building page named "mineshaft" won't work There are by the way more mine nodes than just a mineshaft. The minermainshaft is just the piece miners use to go vertical
— Reply to this email directly, view it on GitHub https://github.com/ldtteam/MinecoloniesWiki/pull/974#issuecomment-1603193090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBGRWNSRWP7Z3PUL7Q4RTTXMSLDDANCNFSM6AAAAAAZQK5WYQ . You are receiving this because you authored the thread.Message ID: @.***>
I think the mineshafts could get their own section instead, together with the mine nodes, instead of putting them in the table of the building requirements
https://wiki.minecolonies.ldtteam.com/source/items/tagtool
In the tag tool its saying that those tags goto the mineshaft but they actually go on the mine blueprint. Would me clarifying that on the tagtool page work? I still think it needs to be clarified somewhere in the style sheet the requirements for a mineshaft. (size, rotation, etc...)
cobble Mine Always 1 The block behind the top-most ladder at the start of the mineshaft (traditionally cobblestone, but may be something else) ladder Mine Always 1 The top-most ladder at the start of the mineshaft
On Thu, Jun 22, 2023 at 7:13 PM Nicholas Chiu @.***> wrote:
@.**** requested changes on this pull request.
Rather than adding a hanging link, adjusting the info to refer to the needed tags in the tag tool would be better since the info is already on the tag tool page.
— Reply to this email directly, view it on GitHub https://github.com/ldtteam/MinecoloniesWiki/pull/974#pullrequestreview-1494115094, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBGRWKP5WT5NUCWHWCEXT3XMTGSXANCNFSM6AAAAAAZQK5WYQ . You are receiving this because you authored the thread.Message ID: @.***>
Rather than adding a hanging link, adjusting the info to refer to the needed tags in the tag tool would be better since the info is already on the tag tool page.
The mineshafts don't use any tags. The mine tags go on the mineshaft part of the building (that is, don't use the ladder tag on any other ladder in the mine building)
so two things are being referred to as the mine shaft. the ladder in the mine hut and the decoration known as minermainshaft.
The fact that the minermainshaft needs to be a certain size and rotation needs to go somewhere on the wiki for people who want to make a style pack. It shouldn't be something that gets re-asked on discord over and over,
On Fri, Jun 23, 2023 at 12:29 AM MotionlessTrain @.***> wrote:
Rather than adding a hanging link, adjusting the info to refer to the needed tags in the tag tool would be better since the info is already on the tag tool page.
The mineshafts don't use any tags. The mine tags go on the mineshaft part of the building (that is, don't use the ladder tag on any other ladder in the mine building)
— Reply to this email directly, view it on GitHub https://github.com/ldtteam/MinecoloniesWiki/pull/974#issuecomment-1603665894, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBGRWKIUWN5IUWTE2DY73DXMULTTANCNFSM6AAAAAAZQK5WYQ . You are receiving this because you authored the thread.Message ID: @.***>
I think the mineshafts could get their own section instead, together with the mine nodes, instead of putting them in the table of the building requirements
Indeed. But as there are 8 mineshaft schematics in total, I think it deserves its own section on the schematics page of the wiki (as I mentioned earlier). Just like the decoration controller has its own section as well
So we can either edit https://wiki.minecolonies.ldtteam.com/source/tutorials/schematics#how-to-create-custom-huts or https://wiki.minecolonies.ldtteam.com/source/items/tagtool
what's the decision?
There are no tags involved with the mine shaft decorations, so tag tool page doesn't make sense.
Somewhere at the bottom of the schematics page is the best place, in my opinion
I agree with MotionlessTrain: the edits should be on the Schematics page, not the Tag Tool page. However, since a mine shaft is not a building, I will still oppose the addition of a hanging link.
no more hanging link and references the scan tool.
There was no information on how to correctly make a mineshaft on the wiki. This should be enough information now for someone who wants to make a style pack.
This does however leave a hanging link to the mineshaft itself.
Closes #
Changes proposed: