ldtteam / Rankup

Minecraft Sponge Auto-ranking plugin
2 stars 1 forks source link

Api 7 buy ranks #12

Closed Asherslab closed 6 years ago

BuildTeamLinter commented 6 years ago

SonarQube analysis reported 38 issues

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR rankup#: Add a 'package-info.java' file to document the 'rankup' package rule
  2. MAJOR Rankup.java#L67: Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 36 to the maximum authorized 30 or less. rule
  3. MAJOR Rankup.java#L266: Either log or rethrow this exception. rule
  4. MAJOR api#: Add a 'package-info.java' file to document the 'api' package rule
  5. MAJOR internal#: Add a 'package-info.java' file to document the 'internal' package rule
  6. MAJOR command#: Add a 'package-info.java' file to document the 'command' package rule
  7. MAJOR configurate#: Add a 'package-info.java' file to document the 'configurate' package rule
  8. MAJOR events#: Add a 'package-info.java' file to document the 'events' package rule
  9. MAJOR listener#: Add a 'package-info.java' file to document the 'listener' package rule
  10. MAJOR core#: Add a 'package-info.java' file to document the 'core' package rule