search

ldtteam / Rankup

Minecraft Sponge Auto-ranking plugin
2 stars 1 forks source link

Fix h2 connection leak #20

Closed flamechair closed 6 years ago

flamechair commented 6 years ago

Tested and verified locally. With this change, the error message doesn't pop up in the console and all functionality that was testable works as expected. This fixes: https://github.com/ldtteam/Rankup/issues/19

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

BuildTeamLinter commented 6 years ago

SonarQube analysis reported 30 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR rankup#: Add a 'package-info.java' file to document the 'rankup' package rule
  2. MAJOR api#: Add a 'package-info.java' file to document the 'api' package rule
  3. MAJOR internal#: Add a 'package-info.java' file to document the 'internal' package rule
  4. MAJOR command#: Add a 'package-info.java' file to document the 'command' package rule
  5. MAJOR configurate#: Add a 'package-info.java' file to document the 'configurate' package rule
  6. MAJOR events#: Add a 'package-info.java' file to document the 'events' package rule
  7. MAJOR listener#: Add a 'package-info.java' file to document the 'listener' package rule
  8. MAJOR core#: Add a 'package-info.java' file to document the 'core' package rule
  9. MAJOR command#: Add a 'package-info.java' file to document the 'command' package rule
  10. MAJOR config#: Add a 'package-info.java' file to document the 'config' package rule
Asherslab commented 6 years ago

Will need to fix the conflicts first thanks =D