search

ldtteam / Rankup

Minecraft Sponge Auto-ranking plugin
2 stars 1 forks source link

API-7 Concurrent Tracks and MySQL #9

Closed Asherslab closed 6 years ago

Asherslab commented 6 years ago

Integrates both branches / PRs into one to make for a simpler merge

Asherslab commented 6 years ago

SonarQube analysis reported 47 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Rankup.java#L67: Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 36 to the maximum authorized 30 or less. rule
  2. MAJOR Rankup.java#L266: Either log or rethrow this exception. rule
  3. MAJOR GroupsConfig.java#L47: Split this 181 characters long line (which is greater than 180 authorized). rule
  4. MAJOR topCommand.java#L97: Assign this magic number 10 to a well-named constant, and use the constant instead. rule
  5. MAJOR CommonUtils.java#L64: Either log or rethrow this exception. rule
  6. MAJOR RankingUtils.java#L13: Add a private constructor to hide the implicit public one. rule
  7. MINOR rankup#: Add a 'package-info.java' file to document the 'rankup' package rule
  8. MINOR Rankup.java#: Add a new line at the end of this file. rule
  9. MINOR Rankup.java#L114: Move this trailing comment on the previous empty line. rule
  10. MINOR Rankup.java#L116: Move this trailing comment on the previous empty line. rule
Asherslab commented 6 years ago

Yeah!