ldtteam / Structurize

Minecraft Structures

GNU General Public License v3.0

45 stars 45 forks source link

Fix/rotate mirror #599

Closed Nightenom closed 1 year ago

Nightenom commented 1 year ago

Supersedes, closes #592 Closes #389 Closes ldtteam/minecolonies#8719

Please test in mcol it actually fixes the issues (did test structurize alone and was working fine)

Changes proposed in this pull request:

Bumps forge/mc requirements (1.20 not accepted)
Replaces renderers cache with guava impl, hopefully won't burn like last time, also slightly adjust renderer hashing
Introduces RotationMirror in favor of deprecated PlacementSettings (the only useful remnant from struct 2.0 xd)
Does NOT replace every usage of PlacementSettings though, will do on next vanilla major

Review please

uecasm commented 1 year ago

FWIW I have a pending feature on the mcol side where I used a guava blueprint cache and it hard crashed due to OutOfMemory very quickly -- but not in my cache, it crashed in the BlueprintRenderer cache. I haven't had time to investigate it too closely yet, but it will be interesting to see if this improves it.