ldtteam / Structurize

Minecraft Structures
GNU General Public License v3.0
44 stars 45 forks source link

Structurize calling incorrect deco schematic on upgrade #635

Closed Moobien closed 8 months ago

Moobien commented 8 months ago

Is there an existing issue for this?

Are you using the latest Structurize Version?

Did you check on the Wiki? or ask on Discord?

Minecraft Version

1.20

Structurize Version

6662 Beta

MineColonies Version (if related bug)

343 Beta

Related Mods and their Versions

No response

Current Behavior

Upgrading fortress road corner 1 instead builds fortress wall corner 2

Expected Behavior

upgrading corner 1 to corner 2

Reproduction Steps

use the versions specified. Have a builder build fortress/roads/corner1 then have the builder upgrade that deco and they will instead build fortress/walls/corner2

I SUSPECT the issue lies in the 2 schematics having the same name but in different folders. instead of grabbing the lvl 2 schematic from roads, it seems to be pulling the schematic with the same name from walls instead.

Logs

n/a

Anything else?

No response

Footer


Viewers

MotionlessTrain commented 8 months ago

It is an issue with how the compatibility between old decoration controllers (1.18-) and new ones work. As the old ones don't know about where they were in the build tool now (they still have the old path from before the rework), they search in the style for the first decoration which happens to have the same name. In case of fortress, both walls and roads are named "corner", which means one of them will find the wrong one instead of the same decoration

Raycoms commented 8 months ago

So, a minecolonies schematic issue.