ldtteam / Structurize

Minecraft Structures
GNU General Public License v3.0
44 stars 45 forks source link

Back to the custom names 1.20 #643

Closed uecasm closed 5 months ago

uecasm commented 7 months ago

Closes discord request

Changes proposed in this pull request:

Review please (could port)

This is a port of #614 but it has a different implementation that doesn't override the building name.

uecasm commented 5 months ago

Not really sure what the difference is between 1.20.1 and main or why the base branch was changed. But what else is needed to merge this?

Thodor12 commented 5 months ago

version/main is now where the porting to 1.20.4 is happening

uecasm commented 5 months ago

version/main is now where the porting to 1.20.4 is happening

Not according to the commit history, it isn't.

Nightenom commented 5 months ago

It stems from miscommunication between Ray and me, when I thought we agreed on making main stale during porting to mitigate conflicts in porting branch (and also mark where did the porting split happen to later merge all unported commits) - this was applied successfully on blockui, not so successfully here..