ldtteam / minecolonies-features

This is a repo only to discuss minecolonies features (requested and planned)
10 stars 3 forks source link

Blacklist for armor and tools being requested #693

Open Saereth opened 2 years ago

Saereth commented 2 years ago

Prerequisites

Context

Is your feature request related to a problem?

Guards currently request modded items that are not craftable, or never craftable which is causing confusion for players. This is especially prevelant in a highly modded pack.

Feature description

A blacklist or a system of adding a specific tag to items that would exclude them from being requested by citizens as armor, weapons or tools would be useful. Even somethin as tag:excluded_from_requests would work wonders to clean up the odd requests in a modded pack. Alternative a whitelisting method would work as well.

Notes or related things

Just as an aside, The ability to override the enchantment level of the item counting towards its vanilla tiering would be nice as well as many modded enchants are functionally not power boost and yet still increase the tier.


Viewers

Moobien commented 2 years ago

They actually ask for ANY tool/weapon/armor that matches the requested level. They do not and have never asked for specific things.

Saereth commented 2 years ago

They cycle through specific things in the fulfillment window and if a player just clicks on them, they initially appear to ask for specific things. For example, the t1 archers will request an enchanted bow from ars. The player nor the mine colonists can craft this item, yet it is what they are asking for by default in this pack. With no way to blacklist that item, it's been very confusing for the players. I've set up a quest explaining they can take other item types, but there is still a lot of confusion regarding it and it's something an exclude tag would solve.

Moobien commented 2 years ago

Too many items to exclude. Devs would have to tag every weapon from every mod. It is not realistic to do. It simply cycles through all possible items that can be used to fulfil the request. If people get confused it isnt hard to jump onto the wiki and learn more.

MotionlessTrain commented 2 years ago

I think a blacklist tag would be easier than a whitelist tag. That means the team doesn't need to tag everything (as everything is included by default, like it is now), but mod developers or modpack developers can blacklist their items if they are not meant for minecolonies' citizens

Saereth commented 2 years ago

yes exactly, and it isnt that much work to tag a bunch of items for pack devs. If I need to blacklist a a dozen and a half weapons I put them all in inventory, dump my inventory with toolkit, paste that into a kubejs array and then iterate over the array to add the tags, all in all it would take like 5mins or so to blacklist every item in the pack that needs it if the tag were simply implemented on minecolony's side.

Moobien commented 2 years ago

Would end up bein up to pack makers then.

Saereth commented 1 year ago

Why would this be better as an addon? There is no APi support for this that I see, so I'd have to mixin your class just to add a simple blacklisting tag. It's like 4 lines of code to do internally for much-needed optional functionality addition when using the mod in a heavily modded pack.