ldtteam / minecolonies-features

This is a repo only to discuss minecolonies features (requested and planned)
10 stars 3 forks source link

[BUG] Snow! Real Magic! snowlogging breaks builders #726

Open Shedao-Shai opened 1 year ago

Shedao-Shai commented 1 year ago

Is there an existing issue for this?

Are you using the latest MineColonies Verison?

Did you check on the Wiki? or ask on Discord?

Minecraft Version

1.19

MineColonies Version

1.19.2-1.0.1094-ALPHA

Structurize Version

1.19.2-1.0.459-ALPHA

Related Mods and their Versions

  1. Forge: 43.1.32
  2. Snow! Real Magic!: 5.0.3

Current Behavior

Snow! Real Magic! allows some blocks (namely stairs, slabs, and fences/fence gates) to be "snowlogged", displaying snow on the model but otherwise functioning exactly like normal. When snow accumulates on these blocks in a structure that is currently under construction, builders attempt to break and replace them, slowing construction needlessly.

Expected Behavior

I would expect the builder to ignore these block variants as they function the same as the original block and drop the original block when broken (a snowlogged spruce stair drops normal spruce stairs when broken).

Reproduction Steps

  1. Have a builder start construction on a building with stairs or slabs exposed to the sky
  2. Change the weather to rain (or in this case snow)
  3. The builder will have a bit of a panic

Logs

https://gist.github.com/Shedao-Shai/921b59230cae94ba3811745601985270

Anything else?

I'll note that Snow! Real Magic! blocks fit extremely well into the aesthetic of spruce-type colonies in snowy biomes, so I would love to see them integrated into structures without causing issues.

MotionlessTrain commented 1 year ago

The builder needs to use the block states, since those determine e.g. the orientation of blocks, whether a slab is a top slab or a bottom slab, the amount of ticks of a repeater, whether a block is waterlogged, etc. If a builder would ignore those, builds would probably have several issues

Shedao-Shai commented 1 year ago

I am reasonably sure that the block is considered a different block, not the same block using a blockstate as in f3 it changes from minecraft:x to snowrealmagic:x without a change in the listed blockstates. Is it possible to allow for such variation in materials?

2022-11-05_12 41 04 2022-11-05_12 41 17 2022-11-05_12 36 38 2022-11-05_12 36 41

MotionlessTrain commented 1 year ago

That gives even more reason for the builder to replace the block. They check whether all block (and block states, as previously mentioned) are correct. If it is a different block, it gets replaced

MotionlessTrain commented 1 year ago

It doesn't work to just ignore the namespace (name of the mod), as two mods can have completely different blocks which happen to have the same name, and it generally wouldn't be desirable if the builder would use one instead of the other

SivartMcDorf commented 1 year ago

I had this on my 1.18 server it was fun but once the blocks are snow-logged they also don't break normally if I remember right they were harder to break if I remember correctly. It obviously doesn't work with DO blocks either. While I like the mod I don't know that it fits with the MC theme due to the DO part of it.

Shedao-Shai commented 1 year ago

In 1.18 SRM broke block hardness, which is an issue that was fixed in the port to 1.19