ldtteam / minecolonies-features

This is a repo only to discuss minecolonies features (requested and planned)
10 stars 3 forks source link

Black banner not working for nordic buildings #754

Closed finntenzor closed 1 year ago

finntenzor commented 1 year ago

Prerequisites

Context

Is your feature request related to a problem?

Related issue: https://github.com/ldtteam/minecolonies/issues/4597

Black banner with below NBT is not accepted:

{BlockEntityTag: {Patterns: [{Pattern: "tts", Color: 11}, {Pattern: "bts", Color: 11}, {Pattern: "mr", Color: 11}, {Pattern: "mc", Color: 1}]}}

However, black banners with below NBT are accepted:

{BlockEntityTag: {Patterns: [{Pattern: "tts", Color: 11}, {Pattern: "bts", Color: 11}, {Pattern: "mc", Color: 11}, {Pattern: "mr", Color: 11}, {Pattern: "mc", Color: 1}]}}

So, the invisible red circle under the red circle prevent players to upgrade their Town Hall to level 4. This is not a programming bug, but an architectural bug.

Enhancement or Change description

Maybe it would be a good idea to update the way these flags are made. Since there are still a lot of players playing 1.12, this update may not require a code change.

Notes or related things


Viewers

MotionlessTrain commented 1 year ago

1.12.2 is not supported anymore