ldtteam / minecolonies-features

This is a repo only to discuss minecolonies features (requested and planned)
10 stars 3 forks source link

"blueprints" folders' "pack.json" files cannot be translated #797

Open mc-kaishixiaxue opened 8 months ago

mc-kaishixiaxue commented 8 months ago

Is there an existing issue for this?

Are you using the latest MineColonies Version?

Did you check on the Wiki? or ask on Discord?

What were you playing at the time? Were you able to reproduce it in both settings?

Minecraft Version

1.20.1

MineColonies Version

1.20.1-1.1.289-BETA

Structurize Version

1.20.1-1.0.653-BETA

Related Mods and their Versions

No response

Current Behavior

I found pack.json in minecolonies...BETA.jar\blueprints\minecolonies\* path, the name and desc texts are both English. They can't be translated to other language on Crowdin, unless I translate them manually. Every time the mod uploads a newer version, I have to translate them again, which are very troublesome.

Expected Behavior

I hope pack.json's name and desc texts can be translated on Crowdin.

Reproduction Steps

  1. Visit https://crowdin.com/project/minecolonies;
  2. I click Chinese Simplified;
  3. Search Urban Savanna, the Crowdin doesn't have it.

Logs

No log

Anything else?

uecasm commented 8 months ago

Currently, this is intended; the names are chosen by the designer of the style and are considered proper names (thus not to be translated).

We are considering ways to translate some aspects of style packs, but there are some complications.

Raycoms commented 8 months ago

I think we could try to resolve it as a translations tring client side? Like, if com.minecolonies.foldername resolves, use that, else just plain.

Raycoms commented 8 months ago

And then the default folder names we add

Nightenom commented 8 months ago

My 2 cents: just add nameTkey (or any other Tkey source) to desirable packs and use that on client if present and if Tkey resolution success via Component.translatable(nameTKey).getString().equals(nameTKey) else use the name just like now

uecasm commented 8 months ago

I already have translation code on a private branch, just waiting for a prerequisite PR.