ldtteam / minecolonies-features

This is a repo only to discuss minecolonies features (requested and planned)
11 stars 3 forks source link

Block names and job names should be separate keys #865

Closed momo-i2 closed 1 day ago

momo-i2 commented 1 day ago

Prerequisites

Context

Is your feature request related to a problem?

There is only one translation for "Sifter", and I think the job and the block name are the same.

Enhancement or Change description

Sifter is a different word for a person and an object in Japanese, so please separate them.

Notes or related things

This may be the case here too, but the discussion on Crowdin is not very active, and even when I send a request on each translation page, I get no response.


Viewers

Thodor12 commented 1 day ago
momo-i2 commented 9 hours ago
  • "com.minecolonies.building.sifter": "Sifter", ->Building name com.minecolonies.building.sifter.desc found, but above one not found
  • "com.minecolonies.job.sifter": "Sifter", -> Job name Can't find it anywhere.
  • "block.minecolonies.blockhutsifter": "Sifter",* -> Block name com.minecolonies.coremod.job.sifter found, but above one not found

Where can I find those translations on Crowdin, I've looked for that 3 files but can only find existing ones?

I'm wondering if this is the same phenomenon as item.minecolonies.mint_tea where the keys are implemented but Crowdin doesn't reflect them.

Thodor12 commented 9 hours ago

I can't quite explain why they're not showing up in crowdin honestly. They're in the source file, they're even already translated according to the output files. I just don't see them in crowdin directly.

The current translations are:

"com.minecolonies.building.sifter": "選鉱師",
"com.minecolonies.job.sifter": "選鉱師",
"block.minecolonies.blockhutsifter": "選鉱師",

As for mint tea, it seems no translation key was made for it at all.