ldtteam / minecolonies

Minecolonies minecraft mod
http://minecolonies.com/
GNU General Public License v3.0
647 stars 332 forks source link

Netherite items no longer return template after cost reduction at blacksmith #10037

Open BrennenCramer opened 1 month ago

BrennenCramer commented 1 month ago

Is there an existing issue for this?

Are you using the latest MineColonies Version?

Did you check on the Wiki? or ask on Discord?

What were you playing at the time? Were you able to reproduce it in both settings?

Minecraft Version

1.20.1

MineColonies Version

1.1.601-BETA

Structurize Version

1.0.738-BETA

Related Mods and their Versions

  1. Forge Version: 47.2.0
  2. BlockUI Version: 1.0.156-RELEASE
  3. Domum Ornamentum Version: 1.0.186-RELEASE-universal

Current Behavior

Whenever The blacksmith reduces the material cost for their netherite recipes (Tools, Armor), the recipe only returns the armor/tool rather than the armor/tool and the netherite template (for which reason the recipe requires an additional 7 diamonds and a block of netherite). image

Expected Behavior

The recipe should produce the item and the template even when the number of diamonds required is reduced OR the recipe should not be eligible for a cost reduction (like with the metal blocks and nugget recipes).

Reproduction Steps

  1. Level up blacksmith to level 5 to unlock netherite crafting.
  2. Produce enough of a piece of netherite gear (for example, the axe) to reduce it's cost.
  3. (Loose) Profit.

Logs

None available. Was encountered on Tropical Colonies server.

Anything else?

Bug was encountered while playing on the tropical colonies patreon server using dedicated pack with small qol addons (journeymap, light overlay, etc.). After a while of mining for extra netherite with which to equip my guards, I began to notice the blacksmith asking for more an more template (I had a massive death wave due to a barbarian attack). When I checked, both my warehouse and the blacksmith had just one remaining template. I had made about 2-3 dozen extra templates before I discovered the issue, assuming it was just a parallelization issue. It may be easiest to simply disable the cost reduction eligibility of the recipe as a short-term fix, as I don't know how the cost reduction code works and how difficult it would be to fix this issue. I'll Just disable the netherite recipes for the time being till this is resolved either way.

BrennenCramer commented 1 month ago

I should add, I am The_Pheonix on the server and my colony is Roc's Roost if you want to see this issue in person.