Resource Scroll shows positive matches when it should not

[Pewmaymen]

Is there an existing issue for this?

• [X] I have searched the existing issues.

Are you using the latest MineColonies Version?

• [X] I am running the latest beta/release version of MineColonies for my Minecraft version. I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

• [X] I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

• [ ] Single Player
• [X] Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.719-1.21.1

Structurize Version

1.0.752-1.21.1

Related Mods and their Versions

Minecraft: 1.21.1 NeoForge: 21.1.57 BlockUI: 1.0.192-1.21.1 Mulit-piston: 1.2.50-1.21.1 Domum Ornamentum: 1.0.204-1.21.1

Current Behavior

Resource Scroll and Builder Required Resources show matches for items of the same TYPE (fence, wall, etc) that are not the correct type. I will attach screenshots that show that the resource scroll shows a requirement for Stripped Oak Log Fence but matches when I have Stripped Dark Oak Log Fence in my inventory. No fences in inventory: Note the all red stripped oak log fence:

Stripped Dark Oak Log Fence in inventory: Note that the Stripped Oak Log fence line item is orange and decreased by the amount of Stripped Dark Oak Log Fences I have in my inventory:

If you have two of the same type (panel for example) listed in the Resource Scroll, having one will satisfy that number for BOTH. When working in the Required Resources interfaces for the Builder, both will show the "transfer" arrow button and you can hit it for both but it will only transfer the correct one in. No error is shown for attempting to transfer the incorrect one in. when you leave the builder interface, both the Resource Scroll and Builder's Required Resource interfaces will update to represent what you have in your inventory. If you don't have any of those item types (still matching based on type, not exact) or insufficient quantity, the entry in the Resource scroll will be red or orange. However, if you have enough of that item Type, whether it is correct or not, the entry will be green.

Expected Behavior

Items should match exactly based on the details and not on the overall item type.

Reproduction Steps

1. Start a job with a Builder that has items of the same type but different styles or materials.
2. Place one of these items in your inventory and observe that both items will show as ready in the Resource Scroll.
3. Alternatively, place a similar but different item in your inventory to see it match an incorrect item in the Resource Scroll.

Logs

There are no log entries during this issue.

Anything else?

No response

Footer

---

Viewers

• Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
• Add a comment if you have any insights or background information that isn't already part of the conversation.

[Raycoms]

That's strange, i can't reproduce this in dev

[Pewmaymen]

This seems like an odd area to have other mods interfere with, but not impossible. I will see what I can do to test and let you know.

On Sat, Oct 5, 2024 at 4:59 AM Raycoms @.***> wrote:

That's strange, i can't reproduce this in dev

— Reply to this email directly, view it on GitHub https://github.com/ldtteam/minecolonies/issues/10315#issuecomment-2394987571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ7HEMSD7OGIKURXWSIF6TZZ6TANAVCNFSM6AAAAABPMX5WYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUHE4DONJXGE . You are receiving this because you authored the thread.Message ID: @.***>

[yepidoodles]

I've also noticed this issue (Both types of roof showing that I have them, but i only have 1 type in my invent)

I have a very bare bones modpack, so there's little chance of conflicts