ldtteam / minecolonies

Minecolonies minecraft mod
http://minecolonies.com/
GNU General Public License v3.0
664 stars 342 forks source link

Can't fire courrier when it's the last one of a warehouse #10323

Open Shazway opened 4 weeks ago

Shazway commented 4 weeks ago

Is there an existing issue for this?

Are you using the latest MineColonies Version?

Did you check on the Wiki? or ask on Discord?

What were you playing at the time? Were you able to reproduce it in both settings?

Minecraft Version

1.20

MineColonies Version

1.1.673-snapshot (Noted as BETA in CurseForge)

Structurize Version

1.0.742-RELEASE

Related Mods and their Versions

No response

Current Behavior

I have a courrier that is the last of the warehouse, shows up in the first screenshot when interacting with the hut block, but no courriers are listed in the manage workers tab

Expected Behavior

When going in manage workers, i can fire my courrier assign them to another warehouse

Reproduction Steps

Have a warehouse (it was lvl4 with multiple courriers before if that helps) Medieval birch if that helps too

Logs

https://gist.github.com/Shazway/c1616a50d65bc6ebc554d435f0bb5b56

Anything else?

image image

Footer


Viewers

Talyda commented 4 weeks ago

I don't know if this is related, but someone on discord was just trying to hire a courier from one warehouse to another, and they noticed that the "show employed" buttons is greyed out as in above screenshots, so I checked mine and it is also. I can have free citizens, and hire them, but can't choose "show employed" button. No idea if it has anything to do with this, but timing seemed sus LOL

Shazway commented 4 weeks ago

That's normal behavior You can only recruit citizens that are courriers in the warehouse, the show employed button shows all employed citizens hence why it's greyed out in warehouses

Talyda commented 4 weeks ago

Oh! D'oh! Yeah, of course! Thanks!