ldtteam / minecolonies

Minecolonies minecraft mod
http://minecolonies.com/
GNU General Public License v3.0
664 stars 340 forks source link

Lumberjack Unable to Find Trees #5994

Closed djhajjar closed 4 years ago

djhajjar commented 4 years ago

Prerequisites

Context

Expected behavior

Locate vanilla trees.

Actual behavior

Unable to locate trees.

Steps to reproduce the issue

  1. Have forester block on edge of colony border.
  2. Outside of border, grow vanilla tree. (in first encounter, 35 blocks away)
  3. At a further distance away from the forester, inside of the colony borders, grow another tree. (in first encounter 50 blocks away)
  4. Lumberjack appears to be in a "no tree found" state despite having a valid target within range.

Logs

No logs available

Notes

Only potential other mod that is interacting is Macaw's Bridges version 1.0.4-mc1.16.3 as a bridge has been placed to allow transversal over a ravine, but as demonstrated by a guard on patrol, a colonist is able to avoid the bridge altogether. Side note, colonists constantly jump on these bridges.

I am running a private server that is up 24/7 and can provide the twitch modpack and ip address if necessary.


Viewers

Raycoms commented 4 years ago

Intentional, forester only gets tree within the colony borders

ravenbuilder934 commented 4 years ago

Their second tree was inside the border

At a further distance away from the forester, inside of the colony borders, grow another tree. (in first encounter 50 blocks away)

Raycoms commented 4 years ago

Depending on the building level there is a distance level for low levels.

djhajjar commented 4 years ago

What's the distance level then? Everything says 150 blocks with no scaling.

ravenbuilder934 commented 4 years ago

I'll go update the wiki on that now

Raycoms commented 4 years ago

I can look into this again. But with a brief glimpse at the code the search-code continues fine. There are some factors that can limit the search but overally the calc is pretty straightforward. What you could test is, if you remove the tree outside the borders, will the Lj take the tree in the 50 blocks distance?

djhajjar commented 4 years ago

I'm currently checking, the day cycled

djhajjar commented 4 years ago

2020-10-27_10 12 07

the tree on teh left is 36 blocks away and the trees on the right are less than 50 blocks away; hut level 2

Edit: The Sappling visible in the middle of the screenshot was placed by the LJ after cutting down a tree

Raycoms commented 4 years ago

can you try to use a normal bridge, like made out of slabs or so?

djhajjar commented 4 years ago

![Uploading 2020-10-27_10.27.39.png…]()

Will try, though the guard does take it

djhajjar commented 4 years ago

2020-10-27_10 27 39

djhajjar commented 4 years ago

2020-10-27_10 30 35

still reports unable to find trees

djhajjar commented 4 years ago

2020-10-27_10 31 03

and the bridge is in the border

djhajjar commented 4 years ago

2020-10-27_10 32 39 there's also this tree Edit: just measured distance, exactly 50 blocks

djhajjar commented 4 years ago

Turned on the restriction mode and the LJ found the trees he couldn't find before; but his pathing was a direct beeline for it and would not find the paths that the others were taking. He was also unable to get to the location as the beeline would have him go outside of the border. Have to go for now.

Also ignored the waypoints I placed.