ldtteam / minecolonies

Minecolonies minecraft mod
http://minecolonies.com/
GNU General Public License v3.0
664 stars 340 forks source link

Emptied milk buckets not being taken from Baker's storage when done with the Milk #6035

Closed Knaxia closed 3 years ago

Knaxia commented 3 years ago

Prerequisites

Context

Expected behavior

Once the baker is done making something that requires milk, the empty buckets are stored, then taken by a courier from their hut and put into the warehouse storage. Which are then delivered to the Cowboy to get more milk.

Actual behavior

Once the baker has completed with the milk, the empty buckets are stored in the Baker's hut storage (main storage or racks) and stay there. No couriers ever go grab them. Even if I call in a courier to come pick up stuff, the buckets will stay in there. I have to manually grab them and drop them into a stash or give them to the cowboy manually.

Steps to reproduce the issue

  1. Have an active warehouse and courier
  2. Have a working cowboy with cows, enabled with "collect Milk" and make sure he has 3 buckets and wait for him to fill them with milk and that they are all put into storage at the warehouse
  3. Have a level 2 baker, which knows how to make a cake
  4. Have a mailbox and request a cake and wait for it to be crafted and delivered.
  5. Wait OR request buckets from the mailbox OR wait for the cowboy to request buckets.

The buckets will stay in the bakery storage unless you manually go there and request a pickup. Otherwise, they will never go and grab it. Even if set to 10/10 priority, it doesn't seem to be an item that is on the list of "needs to grab when unused". Probably because of the cowboy that also requires empty ones.

Logs

None needed, no errors related to them in there.

Notes

I've waited a little for many updates just to make sure, I've started my colony on 0.13.271-ALPHA and ever since I built the bakery, I've always had that problem. In the past, my buckets actually vanished, I couldn't find them anywhere in storage of all my colony and I checked every building / possible storage spot. I made 9 more (enough for 3 cakes per request), they no longer just vanish, but the problem of them staying stuck at the bakery persists.


Viewers

Knaxia commented 3 years ago

I have updated the steps as requesting a pickup from a Courier will actually grab the buckets now (wasn't before). The issue still remains that they will never automatically go and take the empty buckets back.

I have to add that behavior that MIGHT also be affected by the same issue:

Items which are classified as "Usable" (weapons, armor and tools) will always stick in the inventory of people or workplace storage, even if they don't require them or need to use them.

I've seen: -Guard towers with random extra armor pieces in them, swords or even axes, even if the guard assigned to that tower is fully geared -Guards running around with their armor + weapon assigned to their Knight/Archer status, but randomly have other weapons on them at all time, even if it's not their use. Knights with bows and archers with swords. They are probably from fight on barbarians and such , but they always keep just one on themselves and put the rest in their designed tower for pickup.

Raycoms commented 3 years ago

Yes. guards on purpose store another set in case their current one breaks mid battle. That is intended

Knaxia commented 3 years ago

Yes. guards on purpose store another set in case their current one breaks mid battle. That is intended

But even if it's something they don't use? Like a bow on a Knight or an axe on an archer?

ravenbuilder934 commented 3 years ago

I've even seen knights carrying bows in their inventory

Mekle001 commented 3 years ago

I've got a change that fixes milk buckets I'm working on, if I can find the chance to finish debugging it.