[AI] Couriers twitch on ladder.

Moleculor commented 3 years ago

Prerequisites

[x] I am running the latest alpha version of MineColonies and Structurize for my Minecraft version.
[x] I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
[x] I made sure that this issue is not a duplicate of any existing issue.

Context

Minecraft Version: 1.16.4
MineColonies Version: 537
Structurize Version: 104
Related Mods and their Versions: Mostly the Minecolonies pack, with a few additions like Performant.

Expected behavior

I would expect the couriers to pathfind properly.

Actual behavior

The couriers twitch on the top of this ladder for a good minute or so before breaking free. If it helps, this is the level 1 Medieval Dark Oak sawmill.

2020-12-24_14 15 57

2020-12-24_14 18 32

Steps to reproduce the issue

Have a warehouse and courier(s).
Have a level 1 Medieval Dark Oak sawmill positioned so that the shortest path to the hut block is directly over the logs with rails/ladders on them.
Have the sawmill request something the couriers need to deliver.
Play some rave music.

Logs

latest.log: https://gist.github.com/Moleculor/8a3217c1a60f564e52d98570e21c6b79

Notes

Unce unce unce unce!

Viewers

Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
Add a comment if you have any insights or background information that isn't already part of the conversation.

Lielac commented 3 years ago

I also noticed something similar with a level 3 wooden warehouse: its second level is accessible only by a ladder, and the couriers spend a lot of time flailing around unable to climb the ladders to access items on the second level. I eventually replaced the ladders with a little staircase, and so far they've been able to path up that just fine.

Raycoms commented 3 years ago

Fixed in newest

tecnobrat commented 3 years ago

I'm not sure this is fixed. I still am having issues with my courier's getting stuck on ladders in my warehouse.

I think this is the fix you were referring to being in latest? https://github.com/ldtteam/minecolonies/pull/6378

Looking at it, it doesn't seem to fix ladders, only rails.

Raycoms commented 3 years ago

There are rails after those ladders, they tried to take the rails and got stuck afaik.

tecnobrat commented 3 years ago

Okay maybe I should open a different issue, but I'm confirming what @Lielac mentioned earlier that couriers get stuck trying to climb the ladder in the tier 3+ wooden (and other) warehouses. They twitch back and forth for a long time, sometimes forever, unless you recall them back to their hut and let them have another try at it.

Raycoms commented 3 years ago

that's a different issue then. Please open a new one then, with the new info and potentially a way to reproduce it easily.

ldtteam / minecolonies