ldtteam / minecolonies

Minecolonies minecraft mod
http://minecolonies.com/
GNU General Public License v3.0
657 stars 338 forks source link

[BUG] Multi Racks still glitching #9785

Open Moobien opened 8 months ago

Moobien commented 8 months ago

Is there an existing issue for this?

Are you using the latest MineColonies Version?

Did you check on the Wiki? or ask on Discord?

What were you playing at the time? Were you able to reproduce it in both settings?

Minecraft Version

1.20.1

MineColonies Version

1.20.1-1.1.474

Structurize Version

1.20.1-1.0.693

Related Mods and their Versions

n/a

Current Behavior

glitching racks - when 3 or more are touching. z fighting

Expected Behavior

expecting Ray's fix to have stood up to the test of time. seriously though I think this old bug may be back.

Reproduction Steps

load up the test world I have attached. 4 colonial warehouses currently being upgraded (1 for each rotation for teestinng purposes)

have a look at the rack maze and you will see the z fighting.

Logs

n/a

Anything else?

new test.zip

Moobien commented 8 months ago

2024-02-16_05 06 03 2024-02-16_05 13 22 2024-02-16_05 13 31 2024-02-16_05 13 32 2024-02-16_05 13 38 2024-02-16_05 13 46

Shadizar commented 8 months ago

Archwood collective buildings with racks have this a lot too I honestly didn't know it was supposed to have been fixed. (I broke/placed/rescanned after the last commit about it some months ago...still keeps happening)

Moobien commented 1 month ago

@Raycoms

Fast forward 7 months and the glitching racks has evolved from zfighting to full on glitching.

This is tested on current schem server as of today.

1: Paste in caldedonia lvl 5 warehouse in schematic mode 2: observe glitched racks on upper level. 3: break up the walls of racks into stacked pairs or stacked singles and scan. 4: paste in the scan and observe NO glitched racks on upper floor

this current issue is throwing AI issues foir players builders.

Refer to this interaction. https://discord.com/channels/139070364159311872/1003402487417548801/1275213264107864095 continued here. https://discord.com/channels/139070364159311872/1003402487417548801/1276060889933414450

the Master building has no glitched racks, but scanning it and pasting it in DOES cause racks to glitch.

EDIT: this isn't specific to walls worth of racks. this DOES happen also with paired stacks. I had to fix a glitched rack in the steampunk warehouse the other day, and I ONLY do racks in stacked pairs or stacked singles.

Raycoms commented 1 month ago

Can you reproduce this with newly placed racks? Afaik this only happens with old pasted racks