[BUG] Doors/gates that are open are replaced when repaired

tecnobrat commented 7 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Are you using the latest MineColonies Version?

[X] I am running the latest alpha version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

[X] I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

[X] Single Player
[ ] Multi Player

Minecraft Version

1.20.1

MineColonies Version

1.20.1-1.1.494-BETA

Structurize Version

1.20.1-1.0.701-BETA

Related Mods and their Versions

Forge: 47.2.17 BlockUI: 1.20.1-1.0.139-BETA Domum Ornamentum: 1.20-1.0.160-BETA

Current Behavior

When you repair a building that has doors or gates that are in a different state (open instead of closed) than on the blueprint, it replaces them. I believe it happens for trapdoors, or any item that can be "opened".

Expected Behavior

It should not replace doors/gates/trapdoors that are in the correct physical placement, regardless of their open/closed state.

Reproduction Steps

Build a building.
Open the door.
Repair the building.
It replaces the door.

Logs

No log

Anything else?

Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
Add a comment if you have any insights or background information that isn't already part of the conversation.

tecnobrat commented 7 months ago

This also happens with furnaces and beehives. I assume anything with a different current state than the default.

Raycoms commented 7 months ago

It's not a trivial thing to handle because sometimes state (e.g. type) completely changes and the block needs to be replaced. So it would have to be on a heavy case-by-case basis.

ldtteam / minecolonies