[BUG] Aquatica deco upgrades are not oriented

anonymous563 commented 4 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Are you using the latest MineColonies Version?

[X] I am running the latest beta version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

[X] I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

[X] Single Player
[ ] Multi Player

Minecraft Version

1.20.1

MineColonies Version

minecolonies-1.20.1-1.1.566-BETA

Structurize Version

structurize-1.20.1-1.0.731-RELEASE

Related Mods and their Versions

stylecolonies-1.4 domum_ornamentum-1.20.1-1.0.186-RELEASE-universal

Current Behavior

After building and upgrading an Aquatica/infrastructure/connectors/connectorcorner1, I tried to upgrade the connector. The connector was rotated by 180 degrees from the original connector.

Level 1 connectorcorner in a test world:

Level 2, after clicking upgrade on the deco controller, halfway through the build:

I also checked that the schematic was the right orientation in the build tool. It is. Levels 1, 2, and 5 shown.

I've already updated stylecolonies and removed my local install of Aquatica.

Expected Behavior

The connector should overlay the previous level so that they are oriented identically.

Reproduction Steps

Start a colony and a builder.
Build the Aquatica/infrastructure/connectors/connectorcorner1 somewhere aesthetic.
Upgrade that decoration by clicking "upgrade" on the deco controller.
Be sad that your underwater base is now flooded and the colonists can't path through it.

Logs

N/A

Anything else?

Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
Add a comment if you have any insights or background information that isn't already part of the conversation.

Moobien commented 4 months ago

I was chatting with Ray about this last night. I am CURIOUS if it could be related to the fix that @uecasm did a couple of months back. I remember him saying that only the deco controllers in the dome caps would need replacing so I never touched the ones in the compartments as they are essentially the 'roads' of aquatica.

uecasm commented 4 months ago

Any instance where there is a decoration controller as a "child hut" of some parent building or decoration would have needed to be replaced and rescanned. I think standalone deco controllers were safe, but I don't recall if I tested that.

liaowangdezhuzhu commented 3 months ago

I also encountered this problem. As shown in the picture, I built a first-level wall using mirroring, and the first-level wall could be constructed at the correct angle. However, when I upgraded this wall to the second level, its angle changed.

Reproduction Steps

Start a colony and a builder.
Build the Byzantine_for_1.20/Walls/Wall_main/wallmain1
Mirror button must be used once, meaning the mirror button is in the 'on' position.
Upgrade that decoration by clicking "upgrade" on the deco controller.

Anything else?

The only difference with this issue is that it requires using the mirror button once; if not used, the problem won't reproduce.

ldtteam / minecolonies