ldtteam / minecolonies

Minecolonies minecraft mod
http://minecolonies.com/
GNU General Public License v3.0
609 stars 322 forks source link

Possibility to turn the mourning off and on #9974

Closed KamilPacanek closed 1 month ago

KamilPacanek commented 1 month ago

Closes https://github.com/ldtteam/minecolonies-features/issues/840

Changes proposed in this pull request:

[ ] Yes I tested this before submitting it. (I have not) [ ] I also did a multiplayer test. (I have not)

Review please

Thodor12 commented 1 month ago

Hello, thank you for the contribution. However did you check with any of the developers if we actually want this?

I can't speak for the entire team but I reckon we don't want to provide options to turn off gameplay features.

KamilPacanek commented 1 month ago

Hello, thank you for the contribution. However did you check with any of the developers if we actually want this?

I can't speak for the entire team but I reckon we don't want to provide options to turn off gameplay features.

Hi I have not, if this is why it wasn't added in the first place I think PR or issue is the right way to discuss this. It's open source, if the owners do not like that I expect them to state that and reject PRs and close issue. I guess after that happen I can learn how to create own mod to make that change happen.

Thodor12 commented 1 month ago

I checked with Raycoms, we don't accept changes to the config that disable features like so.

Your best approach is to check out https://github.com/gisellevonbingen-Minecraft/MineColonies_Tweaks, they already modify some things in a third party way. Do note that this mod does not belong to us and we do not support the usage of this mod, so you are on your own for that one.

someaddons commented 1 month ago

Mourning is an important core mechanic to the game, which serveral other things rely on, we dont allow disabling those things via config. Also please do not use minecolonies tweaks its a hacky and invasive way of undermining the design of minecolonies that is going against the creators whishes.