[BUG] Using a comma in the stock stack amount results in the block being unusable

Danyo1301 commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing issues

Are you using the latest MineColonies Version?

[X] I am running the latest beta version of MineColonies for my Minecraft version.

Did you check on the Wiki? or ask on Discord?

[X] I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

[X] Single Player
[ ] Multi Player

Minecraft Version

1.20.1

MineColonies Version

1.1.586-BETA

Structurize Version

1.0.736-BETA

Related Mods and their Versions

Added it to the latest direwolf20 pack originally when I first encountered it, but was able to reproduce this in a standalone instance with just minecolonies (and dependencies), used the same forge version though.

Current Behavior

In the restaurant I wanted to keep a stock of bread, but just for testing purposes, I decided that started with half a stack would be fine. So in the number of stacks to keep, I placed "0,5" and pressed okay. Straight after this the restaurant and the bakery both became unresponsive, and I had to restore a back up to fix it.

Expected Behavior

I would expect either for the number to be ignored (which it looked like initially when I pressed accept, before closing the gui), or just round off or something. Maybe get some feedback when trying to do so that it doesn't work?

Reproduction Steps

Put 0,5 as the stock to keep in the restaurant of bread Have a bakery Have both manned by a citizen I did not have enough wheat in my warehouse at this point.

Logs

[04Jun2024 14:53:55.412] [Server thread/INFO] [minecolonies/]: Colony 1 - removed AbstractBuilding BlockPos{x=-477, y=70, z=28} of type baker [04Jun2024 14:53:55.415] [Server thread/INFO] [minecolonies/]: Colony 1 - removed AbstractBuilding BlockPos{x=-485, y=71, z=35} of type cook [04Jun2024 14:54:00.910] [Render thread/WARN] [minecolonies/]: Invalid input in Selection BOWindow for Quantity, defaulting to 1! [04Jun2024 14:54:16.871] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [System] [CHAT] This block is missing its respective building, try restarting or loading a backup! [04Jun2024 14:54:21.066] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [System] [CHAT] This block is missing its respective building, try restarting or loading a backup! [04Jun2024 14:54:25.669] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [System] [CHAT] This block is missing its respective building, try restarting or loading a backup!

Anything else?

Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
Add a comment if you have any insights or background information that isn't already part of the conversation.

Raycoms commented 1 month ago

Huh, I cannot reproduce thi.

Raycoms commented 1 month ago

Can you give us a larger log, it seems something else removed the building before the wrong input already

ldtteam / minecolonies