ldtteam / minecolonies

Minecolonies minecraft mod

http://minecolonies.com/

GNU General Public License v3.0

609 stars 322 forks source link

Improve fisher #9986

Closed Raycoms closed 2 weeks ago

Raycoms commented 3 weeks ago

Closes # Closes # Closes #

Changes proposed in this pull request:

Fix fisher running into water to fish from there
Fix fisher not being able to stand on certain slabs etc to fish.
Fix fisher derping when going through water when going to a fishing pos
Fix and cleanup undertaker

[ x ] Yes I tested this before submitting it. [ ] I also did a multiplayer test.

Review please

uecasm commented 3 weeks ago

Is it worthwhile to add an optional tag for suggested "stand here" locations when fishing nearby? (Pick one at random if within X blocks of chosen water spot.) Some styles have a very well-defined pier or similar that's intended to be used for fishing, but often gets ignored.

Raycoms commented 3 weeks ago

Is it worthwhile to add an optional tag for suggested "stand here" locations when fishing nearby? (Pick one at random if within X blocks of chosen water spot.) Some styles have a very well-defined pier or similar that's intended to be used for fishing, but often gets ignored.

From my superficial tests this should be much better now as well. They finally use these.