search

lduarte1991 / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
12 stars 7 forks source link

Updating to Django 1.11.20 #100

Closed lduarte1991 closed 5 years ago

lduarte1991 commented 5 years ago

Steps taken to update this:

  1. Updated Django to 1.11.20
  2. removed django-jenkins from installed apps
  3. set allowed_hosts in secure.py if not done already
  4. changed urls.py to remove "patterns" function
  5. Added contrib.sites and SITE_ID to settings.py
  6. Changed way to get get_current_site function from shortcuts
  7. Update django-crispy-form to 1.7.0
  8. Added exclude and/or fields attribute in forms
  9. Changed template settings in settings.py
  10. Update django-bootstrap-3 to 11.0.0
  11. Changed context_processors that come from core module to template
  12. Updated django-extensions to 1.6.7
  13. Run migration on sites if necessary

Note: running this branch, updating to new requirements.txt should be all that's necessary. Unfortunately SITE_ID may not actually trigger the sites app migration as it should so it may have to be done manually by running ./migrate.py sites.

lduarte1991 commented 5 years ago

@arthurian I'm considering updating django to the latest 2.0.x version...but I think we'll wait until we do some major rework in our production environment. Let's chat offline when you are available.

arthurian commented 5 years ago

@lduarte1991 PR looks good to me! I agree that upgrading to Django 2.x would be good, but probably not a trivial undertaking.

lduarte1991 commented 5 years ago

@arthurian Agree on 2.x, I actually tried to do it, but it was such a huge change, I had to stop and save it for when we clean up some stuff in a few months. 👍 Thanks!