Closed arthurian closed 3 years ago
@arthurian Can definitely merge this asap. just let me know that it doesn't clash with any of the other you've submitted and I'll do it now.
@lduarte1991 There shouldn't be any conflict with the other PRs, so feel free to merge when ready.
This PR fixes an issue with youtube videos not loading due to incorrect playback tech being used by videojs. It looks like the videojs youtube tech is expecting the source type to be
video/youtube
, otherwise it won't work.Notes:
https://youtu.be/ID
orhttps://www.youtube.com/watch?v=ID
and sets thesource_type
tovideo/youtube
, otherwise defaults tovideo/mp4
.hxighlighter_video_vjs.js
to fix a related issue with the videojs youtube tech. This change can be merged before that, since it shouldn't negatively affect any existing functionality. See also: https://github.com/lduarte1991/Hxighlighter/pull/24@lduarte1991