search

lduarte1991 / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
13 stars 7 forks source link

Instructor Dashboard View Changes #27

Closed arthurian closed 8 years ago

arthurian commented 8 years ago

This PR refactors the instructor dashboard view to only depend on the CATCH for retrieving user/annotation info. I've moved all of the helper methods into the hx_lti_initializer.utils module.

Note: the limit search parameter is still hard coded to return a maximum of 10,000 annotations. We'll have to address this at some point, although for ATG's purposes it should be more than enough.

@lduarte1991 Thoughts?

lduarte1991 commented 8 years ago

In what way would you propose to change the limit search parameter? Are you worried that 10K is too much and will break everything while loading that many annotations or are you worries it's too little?

Cause if you think it's too much then I hate to break it to you but it struggles with a few hundred annotations, let alone 10K haha.

If you think it's too little, we can just set it to -1 for "get all of them".

arthurian commented 8 years ago

I suppose if it struggles with just a few hundred, let alone thousands, then pagination is probably the way to go. For now, should we just set it to -1 to "get all of them" until we implement pagination?

lduarte1991 commented 8 years ago

sounds good. should i merge now?

arthurian commented 8 years ago

Sure! :+1:

lduarte1991 commented 8 years ago

:+1: