lduarte1991 / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
12 stars 7 forks source link

fix_template_role_checks #43

Closed arthurian closed 8 years ago

arthurian commented 8 years ago

This PR fixes an issue in Canvas with checking administrator/instructor roles. It removes explicit roles checking in the templates (vestiges of pre-merge), since the roles are not consistent across platforms (i.e. edX and Canvas). Better to just check if the user has instructor-level permission via the is_instructor session variable.

Note: I also removed the test pages which had the same issue, but since they aren't needed for anything anymore, figured it would be easier to just remove them altogether.

@lduarte1991 Does this look OK?

lduarte1991 commented 8 years ago

:+1: