lduarte1991 / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
13 stars 7 forks source link

default_pagination_limit #44

Closed arthurian closed 8 years ago

arthurian commented 8 years ago

This PR adds the ability to configure the default pagination limit from the environment settings (i.e. secure settings), so that different environments can set an appropriate default. This setting will populate the assignment form as the default, but of course, the instructor/admin can change it. The existing default is 20, so if no value is provided that will remain the default.

Note: this was motivated by an issue we noticed with paginated text annotations (>20 annotations per text). We noticed that instead of loading the first page of annotations according to the order in which they appear in the text, it loads later annotations first. This leaves the user confused as to why the early part of the text doesn't show their annotations and no indication is given that they need to scroll to load them. The workaround is to simply increase the pagination limit, which is what this PR is focused on.

@lduarte1991 Does this look OK?

lduarte1991 commented 8 years ago

:+1: