lduarte1991 / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
12 stars 7 forks source link

Admin Hub Updates #73

Closed arthurian closed 7 years ago

arthurian commented 8 years ago

PR Description Updated 9/28/16


This PR contains a number of changes that have accumulated over the course of the summer/fall. I'll try to enumerate the changes below.

  1. Fixes a small error on the admin hub's instructor dashboard. Apparently the Queryset.extra method is soon to be deprecated and it was causing an issue with the generated SQL query, so I just removed it and replaced it with a python equivalent.
  2. Re-includes the bootstrap CSS and JS files for the instructor dashboard. If we don't want to have bootstrap, we just need to refactor the dropdown-menu and the collapse/expand functionality on that view.
  3. Fixes the focus_on_annotation behavior when linking to a specific annotation from the instructor dashboard. Removed some extraneous code that didn't appear to be needed anymore from annotation_base.html and refactored the call to _clearAnnotator(), so that it excludes the focused annotation from being cleared.
  4. Fixes a few small issues with creating new assignment sources (text, image, video). For instance, the popup window wasn't closing/saving correctly.
  5. Refactors settings/aws.py to decouple the ORGANIZATION setting from other settings. Since this was mostly used to implement ATG-specific changes, removing that conditional block shouldn't break anything for HarvardX.
  6. Fixes the iframe size in Canvas by triggering the lti.frameResize message on both the admin hub and annotation main page.
  7. Fixes issue with Test Student view in Canvas (denied access).
  8. Enhances the django admin interface so more information is displayed in the list view so that you don't have to drill down as much and can search by course, assignment, or target name.
  9. Adds the ability for instructors to publish/unpublish assignments (assignments are published by default, so as not to change the existing behavior). This is mostly targeted toward Canvas users, since it doesn't make as much sense for edX usage. When an assignment is unpublished, it is completely inaccessible to students. Instructors might use this to pre-populate their tool with assignments, and then publish as needed.
arthurian commented 8 years ago

@lduarte1991 Just following up on this PR. Any questions or concerns with any of the proposed changes?

arthurian commented 8 years ago

@lduarte1991 I just updated the PR description to bring it up-to-date with all of the changes that have taken place on the admin_hub_v2 branch of https://github.com/Harvard-ATG/annotationsx. I'll walk you through it when we meet next.