Closed arthurian closed 7 years ago
@lduarte1991 Just following up on this PR. Any questions or concerns with any of the proposed changes?
@lduarte1991 I just updated the PR description to bring it up-to-date with all of the changes that have taken place on the admin_hub_v2 branch of https://github.com/Harvard-ATG/annotationsx. I'll walk you through it when we meet next.
PR Description Updated 9/28/16
This PR contains a number of changes that have accumulated over the course of the summer/fall. I'll try to enumerate the changes below.
Queryset.extra
method is soon to be deprecated and it was causing an issue with the generated SQL query, so I just removed it and replaced it with a python equivalent.focus_on_annotation
behavior when linking to a specific annotation from the instructor dashboard. Removed some extraneous code that didn't appear to be needed anymore fromannotation_base.html
and refactored the call to_clearAnnotator()
, so that it excludes the focused annotation from being cleared.settings/aws.py
to decouple theORGANIZATION
setting from other settings. Since this was mostly used to implement ATG-specific changes, removing that conditional block shouldn't break anything for HarvardX.lti.frameResize
message on both the admin hub and annotation main page.