lduarte1991 / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
13 stars 7 forks source link

Fixes issue with permissiondenied error with a starting resource. #76

Closed arthurian closed 7 years ago

arthurian commented 7 years ago

@lduarte1991 I just looked at this branch and that's more or less what I had in mind. While I was testing it out, I discovered one unexpected thing with unpublished objects: rather than denying students access to unpublished to the object, it falls back to the admin hub view.

This PR changes that behavior so that if a PermissionDenied exception is raised when accessing an annotation target object, the exception is re-raised instead of defaulting to the admin hub view.

In addition to that change, I made these tweaks as well:

arthurian commented 7 years ago

@lduarte1991 I just updated this PR with the ability to de-select a starting resource. Take a look and let me know if the changes look OK to you.

lduarte1991 commented 7 years ago

looks great to me 👍 will merge in a bit.