search

lduarte1991 / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
13 stars 7 forks source link

LTI Grade Passback Fixes #93

Closed arthurian closed 6 years ago

arthurian commented 6 years ago

@lduarte1991 This should fix issue #91 and ensure that the proper secret for the course is used when submitting the outcome request.

One thing to note is that while testing in Canvas, we had to upgrade ims_lti_py to the latest version in order to get the outcome request to work. Unfortunately, ims_lti_py didn't have a new release on github or on PyPi, so we pointed the requirements to the develop branch.

Also, I removed the statistics gathering code in the store since the advent of catchpy should make that obsolete.

Let us know if this doesn't resolve the issue on your end.

lduarte1991 commented 6 years ago

@arthurian checking through this over the next few days. From a quick skim, there's nothing in these commits that look like a red flag from our end and things seem to be working seamlessly so far. I'm going to give it until middle of next week. If there are still no issues, I'll merge. Thanks a lot for all this great work!

lduarte1991 commented 6 years ago

@arthurian 👍 I think I'm ready to merge this. Any last reason I should not?