lducas / FHEW

Other
221 stars 46 forks source link

More gates supported natively #15

Closed lducas closed 7 years ago

lducas commented 7 years ago
lducas commented 7 years ago

Apologies for the ``white-space'' noise. My editor is not so clever and has trouble with for-loops without brackets.

micciancio commented 7 years ago

Gates look fine, can be merged as it is. Comments below are mostly for readability, and can be addressed later.

HomGate: condition on dependent ciphertexts includes also ciphertexts that are neither equal not one the negation of the other. (Each a[i] can be negated independently.) No need to change, as condition is a conservative approximation, and false positives have exponentially small probability. Also, "+q/4" term in call to InitializeACC could be moved to GateConst table.

fhewTest: very hard to follow, both code and output. Fine for testing, but not a good example on how to use library.