ldx / python-iptables

Python bindings for iptables
730 stars 182 forks source link

fix locating _xtables_libdir with glibc >= 2.32 #322

Closed mwhudson closed 1 year ago

mwhudson commented 3 years ago

It appears ldconfig -v changed its output in glibc 2.32 and now looks like this:

/lib/x86_64-linux-gnu: (from /etc/ld.so.conf.d/x86_64-linux-gnu.conf:3) libplds4.so -> libplds4.so ...

This breaks the regex xtables.py is using to look for the linker search path, so I've adjusted the regex to work with the old and new formats.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 58.203% when pulling 18d326d7de57186c88583bdeb0a2ace59ef14b75 on mwhudson:glibc-2.32 into 542efdb739b4e3ef6f28274d23b506bf0027eec2 on ldx:master.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 58.203% when pulling 18d326d7de57186c88583bdeb0a2ace59ef14b75 on mwhudson:glibc-2.32 into 542efdb739b4e3ef6f28274d23b506bf0027eec2 on ldx:master.

EvanKrall commented 1 year ago

@ldx Can this PR or #330 be merged? It looks like #329 affects Ubuntu 22.04 (Jammy).

ldx commented 1 year ago

@ldx Can this PR or #330 be merged? It looks like #329 affects Ubuntu 22.04 (Jammy).

Merged #330.

ldx commented 1 year ago

Thanks for the PR! Since #330 fixes the problem, closing this one.