le-michael / ElmJrMetalEdition

2 stars 0 forks source link

Transpiler Refactor #121

Closed Khan-Saad closed 3 years ago

Khan-Saad commented 3 years ago

Alright this is the PR for the transpiler refactor + animation functionality.

Currently missing features in this PR: -Grouping -Optionals for ArcballCamera -Need proper logic for converting to radians when time is involved. Currently radians only work for rotation, and it also converts all constants into radians regardless of if that is desired. Hence why I multipled the elm code for the hand by pi*180.

A few clarification questions are needed: -What is the color parameter within SceneWithTime Camera Color (List Light) (Float -> List Shape). Not sure what that represents. -Lines 302 and 321, the cases below im not sure if I have the correct corresponding strings.

Otherwise this should be able to handle any Elm Code.