search

leMaik / chunky

Photorealistic image renderer for Minecraft 1.2.1+
https://chunky.lemaik.de
GNU General Public License v3.0
40 stars 1 forks source link

Internal glass surface rendering #5

Closed jackjt8 closed 4 years ago

jackjt8 commented 4 years ago

Following discussions on Discord regarding coloured shadows created by Stained Glass two issues with how Stained Glass is being rendered have been noted. This is following off of upstream issue https://github.com/llbit/chunky/issues/450

Behaviour in 1.X is seen to be incorrect as all occluded surfaces are not rendered which is not the behaviour seen in Minecraft; where only adjacent Glass with the same Namespace ID's are.

Glass Rendering in 1.X 1 4 6_colored_shadows

Glass Rendering in Game 2020-02-24_23 44 46

Chunky 2.0 - Glass behaviour was adjusted to be much closer to Minecraft however it is not perfect. 2 0_beta6_colored_shadows

[ ] Internal surface between two adjacent & different glass blocks have an increased brightness compared to Minecraft. 2 0_beta6_colored_shadows_brightsurface

[ ] Internal surface shows incorrect culling of occluded adjacent surfaces of glass with different Namespace IDs 2 0_beta6_colored_shadows_lines

jackjt8 commented 4 years ago

Additional images of the two issues:

2020-02-25_12 51 26

default-64

It looks like the occlusion system isn't working correctly for glass viewed through glass. Doesn't appear to be related to one surface in particular.

jackjt8 commented 4 years ago

default-64

I removed the adjacent rear blocks. As can be seen... The single rear block is being rendered on all sides.

leMaik commented 4 years ago

glass-541

It now looks like ingame, will be in the next snapshot.