leadedge / Spout2

A video frame sharing system for Microsoft Windows
BSD 2-Clause "Simplified" License
747 stars 137 forks source link

Spout Panel does't display more that 10 Senders #33

Closed Harvey3141 closed 4 years ago

Harvey3141 commented 6 years ago

Hi Lynn,

I think I have found a bug where there the Spout panel app can only handle up to 10 senders. This also seems to be apparent when getting the list of available senders from the SpoutSDK.

I've created an Openframeworks project which shows the problem. - https://goo.gl/MQVpgC it uses this Spout addon - https://github.com/ThomasMSondrup/ofxSpout2 with the latest Spout SDK version, there's a compiled version in the Bin folder. Once running press 'a' to add spout senders one at a time. If you check the Spout Panel after reaching 10+ running senders you should what I mean.

Thanks, Harvey

leadedge commented 6 years ago

Hi Harvey,

This maximum sender number problem has come up more recently with Touchdesigner. It was fixed by setting the maximum sender size with "SetMaxSenders(int maxSenders)".

The idea is that by the time of the next Spout release, all applications should have updated to at least 2.005 where the maxSenders registry setting is used. Then the option will be included in the settings application. Meanwhile you can use SetMaxSenders in the first application that starts.

I thought you were using this already. It might be best if I send you the latest settings dialog program by email. I tested with a Spout 2.006 installation setting the maximum number to 12 and opening 12 demo senders. Then with a receiver, SpoutPanel (Vers 2.20) shows all 12 OK. It should be possible for you to reproduce this.

Somehow the first link goes to the addon repository. If you can post the link again I will try the executable.

12_senders

Harvey3141 commented 6 years ago

Hi Lynn,

I haven't seen this issue up until now as I've been explicitly creating receivers without using the Spout Panel or needing to retrieve the list of sender names. But yes the issue does seem to be the same as the TD one.

Before running any sending/receiving apps I have been running the Utility you sent for setting Max number of senders, actually, this is only done once per installation. Our application which creates the Spout receivers also calls SetMaxSenders(30), in my test I am running this first. I then run my sending app (correct link https://goo.gl/Dz6qLA). I've just installed using the latest 2.006 install with Spout Panel 2.20 but I am still seeing the same issue.

If you could you check whether you are seeing the same that would be helpful.

Thanks

Harvey3141 commented 6 years ago

As a further test, I tried.

  1. A reboot
  2. Running the "SpoutDXMode Utility" and setting max senders to 30
  3. Opening 12 Spout senders using the SpoutSender.exe in the spout 2.006 installer
  4. Opening the spout panel v.2.20

And I see the same, senders names ending 8 and 9 are missing, if you scroll up you can see sender name ending 0 and 1

screenshot_030118_124921_am

leadedge commented 6 years ago

My omission not to check that all the senders were there. I found the problem. SpoutPanel uses the SpoutSenderNames class which sets the maximum sender number to 10 by default. SpoutPanel was not checking the registry entry to update this. Attached is an update. Let me know if it works for you.

SpoutPanel.zip

Harvey3141 commented 6 years ago

OK, that makes sense and yes the panel list is working now, thanks.

sheridanis commented 6 years ago

Thanks lynn much appreciated

Also +1 for bring able to set or at least view the max senders in the control app again.

Sent from my microwave

On 1 Mar 2018, at 23:27, Harvey Buchan notifications@github.com wrote:

OK, that makes sense and yes the panel list is working now, thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

leadedge commented 6 years ago

I believe that this change will not affect any existing applications and enough time has passed that all should be up to date with 2.005 or later, so an update release is probably worth while rather than waiting for the next version.

Since you have been using this for a while, have you found this setting to be stable and cause no problems?

leadedge commented 4 years ago

Presumably the setting has been stable.