Closed dimitre closed 2 years ago
Thanks Dimitre
yes this is an oversight. The shader files should be removed from the from the repository src folder. Perhaps another folder should be added containing them :
data/shaders/rgba2yuv/ with ES2, GL2, GL3 subfolders and files
Then change "addon_config.mk" to include :
ADDON_DATA = data/shaders
Here's an example that does this :
https://github.com/timscaffidi/ofxVolumetrics
What do you think?
I think it is a great idea. moving out of src files already helps for the compiler thing I can test here any changes
OK I will make the changes over the next few days.
I have made changes to the "testing" branch, following the example I gave. If you could test that would be good.
Just checked out "testing" and it gave me some errors related to MAX_COMPUTERNAME_LENGTH (undefined) and unknown type name DWORD
This was an attempt to remove a deprecated warning.
warning C4996: 'NDIlib_v5::NDIlib_send_get_source_name': was declared deprecated
We could define MAX_COMPUTERNAME_LENGTH which is in WinBase.h. DWORD is used by GetComputerNameA. A conditional compile for non-Windows would solve it as long as the deprecated warning is not a problem.
In Processing.NDI.DynamicLoad.h we see
// V3.8 union { const NDIlib_source_t (send_get_source_name)(NDIlib_send_instance_t p_instance); PROCESSINGNDILIB_DEPRECATED const NDIlib_source_t (NDIlib_send_get_source_name)(NDIlib_send_instance_t p_instance); };
But the SDK documentation still clearly refers to the function.
There are also some re-definition warnings in ofxNDIutils.cpp that I will fix.
Personally, I usually don't use much addon_config.mk if is not required. the /data could be moved manually when creating new project.
Master branch is now updated from Testing with these changes. I will update from there if any errors remain.
Thanks, now the errors I see in git master are: examples sources are outside src/ folders and this other ones here Thanks
Also addon_config.mk was not updated from the testing branch
with this change project generator don't try to include shaders and txt file in the sources to compile (at least in macOS)