search

leadedge / ofxNDI

An Openframeworks addon to allow sending and receiving images over a network using the NewTek Network Device Protocol.
GNU General Public License v3.0
134 stars 48 forks source link

README could be commented... #36

Closed moebiussurfing closed 2 years ago

moebiussurfing commented 2 years ago

Hello @leadedge , just a small thing…

When creating a new oF project with the Project Generator, the standard workflow, that file is causing errors: then must be commented or deleted manually.

https://github.com/leadedge/ofxNDI/blob/master/src/shaders/readme.txt

Maybe you can comment the content or to move the file if you like. To avoid this manual remove...

Here I am on Windows10 / VS 2022

moebiussurfing commented 2 years ago

sorry, I didn't seen that pull https://github.com/leadedge/ofxNDI/pull/35

leadedge commented 2 years ago

Actually this is pending testing but another problem came up. You could help with a test so I can clean it up and finalise the change.

moebiussurfing commented 2 years ago

I just compiled the receiver example on test branch and it worked

leadedge commented 2 years ago

Excellent. Thanks for that. I will go though everything and update the master branch.

moebiussurfing commented 2 years ago

tell me if go test another thing. I cleaned the data folder too from the dlls. PG seems that copies the shaders folder and all is working.

moebiussurfing commented 2 years ago

sorry my mistake. dlls are copied fine to bin/ I deleted all in the example project, except /src, and it works. thanks for the updating.

leadedge commented 2 years ago

OK thanks, I will proceed with update of the master branch.

moebiussurfing commented 2 years ago

hmm I am not sure, but I suspect that when creating the project with PG, if there's a folder called bin/data/shaders it deletes and overwrites the folder,

Maybe another non common name could be better than /shaders/

But I am not sure.. I just noticed that that folder disappeared...

leadedge commented 2 years ago

It could be the expected behaviour of the program generator. Normally if you generate a program, the application folder would not exist. I will have a look at this.

moebiussurfing commented 2 years ago

On VS2019 and beyond, the oF extension for VS to add add-ons during session do not work.

Then, if you have a ready to use project with other stuff, and you decide to add ofxNDI, you must close VS and open of PG to add ofxNDI and to rebuild the project. Then if you have a folder /bin/data/shaders, this folder will be deleted.

That's the point I see... /shaders/ is maybe a common name used maybe by other ofxAddons.

leadedge commented 2 years ago

I think I found the problem as described in addon-config.mk

# Variables can be specified using = or += # = will clear the contents of that variable both specified from the file or the ones parsed from the file system # += will add the values to the previous ones in the file or the ones parsed from the file system

I have found that it's common to see data folders "shaders", movies", "fonts" etc. and the mk file change would probably fix it, but in any case to avoid possible conflict I have put "rgba2yuv" directly in the data folder and changed the source to find it.

ADDON_DATA = data/shaders is now changed to ADDON_DATA += data/rgba2yuv

Hopefully this will work OK.