search

leaderboardsgg / leaderboard-site

Frontend of Leaderboards.gg
https://leaderboards.gg/
GNU General Public License v3.0
57 stars 21 forks source link

Rewrite Tests to be working and running in Vitest properly #504

Closed buffet-time closed 1 year ago

buffet-time commented 1 year ago

What

Fixing ViTest so that tests work!

Link to Issue

Closes this: https://github.com/leaderboardsgg/leaderboard-site/issues/503

Acceptance

Tests, Dev, and Build all work.

Steps for testing

run pnpm test and ensure all tests go green.

Also run pnpm dev to ensure the tests did not break dev setup

And lastly run pnpm build and ensure the build finishes properly.

buffet-time commented 1 year ago

Gonna be honest but I've only skimmed through package.json as it's tedious to map what was removed, or simply rearranged. But of course, looking at CI passing should mean things are alright.

Also; what's the plan with all the commented-out tests?

The plan is to get them re-written into Vitest + vue-test-utils, they're a bit more complicated to rewrite. But I don't want them to hold back and we can do some more manual testing of that functionality in the mean time.